Skip to content

Cody/feature/fetch zoom webinar occurrences #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shaunagm merged 2 commits into from
Jul 1, 2025
Merged

Cody/feature/fetch zoom webinar occurrences #1500

shaunagm merged 2 commits into from
Jul 1, 2025

Conversation

@codybraun
Copy link
Contributor

@codybraun codybraun commented Jul 1, 2025

What is this change?

  • A member wants access to the occurrences of a webinar- turns out a webinar is not a single session, it can be a recurring thing with many instances. We have a member who wants to track the occurrences over time, which makes sense

Considerations for discussion

  • It doesn't appear that meetings also have occurrences, this seems to be just a webinar thing
  • It is also a little weird that there is not an occurrence_id on things like webinar attendances... I guess you just have to use the timestamp to know which instance of webinar they attended.

How to test the changes (if needed)

  • pytest test
  • or in a REPL:
zoom.get_webinar_occurrences('89216100225')
zoom INFO Retrieved 17 webinar occurrences.
{'occurrence_id': '1753401600000', 'start_time': '2025-07-23T00:00:00Z', 'duration': 60, 'status': 'available'}
{'occurrence_id': '1756425600000', 'start_time': '2025-08-27T00:00:00Z', 'duration': 60, 'status': 'available'}
{'occurrence_id': '1758844800000', 'start_time': '2025-09-24T00:00:00Z', 'duration': 60, 'status': 'available'}
{'occurrence_id': '1761264000000', 'start_time': '2025-10-29T00:00:00Z', 'duration': 60, 'status': 'available'}
{'occurrence_id': '1764291600000', 'start_time': '2025-11-28T01:00:00Z', 'duration': 60, 'status': 'deleted'}

codybraun
codybraun commented Jul 1, 2025
View reviewed changes
parsons/zoom/zoom.py
return tbl

def get_user_webinars(self, user_id):
def get_webinar_occurrences(self, webinar_id: int) -> Table:
Copy link
Contributor Author

@codybraun codybraun Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only actual change here- I just added type hinting since I've been doing that elsewhere in Parsons but shout if you want me to quit it

Copy link
Collaborator

@shaunagm shaunagm Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the type hints are great! on this PR it isn't even an issue of making the PR harder to read because there's one commit with the changes and one commit with the type hints so I can just view them separately :)

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  parsons/zoom
  zoom.py
Project Total  

This report was generated by python-coverage-comment-action

IanRFerguson
IanRFerguson approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@IanRFerguson IanRFerguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - it's just an endpoint we can hit? glad we don't have to do any gnarly loops, thanks for knocking this out

@shaunagm shaunagm merged commit 2117c19 into main Jul 1, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IanRFerguson IanRFerguson IanRFerguson approved these changes

@shaunagm shaunagm Awaiting requested review from shaunagm

@KasiaHinkson KasiaHinkson Awaiting requested review from KasiaHinkson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codybraun @shaunagm @IanRFerguson